lbl-srg / obc

OpenBuildingControl - Performance Evaluation, Specification, Deployment and Verification of Building Control Sequences
http://obc.lbl.gov
26 stars 14 forks source link

Pull request to fix VAV heating coil sizing issue #108

Closed karthikeyad-pnnl closed 2 years ago

karthikeyad-pnnl commented 2 years ago

@mwetter : Hi Michael,

I am submitting this pull request to resolve the simulation initialization error observed, where the heating coil effectiveness is calculated to be greater than 1. I have added a new multiplying factor to the expression for mHeaVAV_flow_nominal, and also created a new parameter variable eps_errorResolution_sizingFactor to record the use of the additional factor. I was not able to use this variable directly in the expression as Dymola could not translate it.

I have also made changes to the validation script for the model, which previously used an incorrect subplot number of 102 for the second subplot.

Thanks, Karthik