lbl-srg / obc

OpenBuildingControl - Performance Evaluation, Specification, Deployment and Verification of Building Control Sequences
http://obc.lbl.gov
26 stars 14 forks source link

Issue92 case study full hvac #119

Closed karthikeyad-pnnl closed 2 years ago

karthikeyad-pnnl commented 2 years ago

@mwetter : Hi Michael,

I am submitting this PR to pull in the changes to the minimum flow setpoint logic. I have replaced the unit delay block with an integrator to break the algebraic loop, which should reduce the number of events during simulation. I ran the unit tests and the results for the new logic are almost identical to the old logic. The additional changes to unit test result files are due to the issue I emailed you about on Thursday.

Thanks, Karthik

mwetter commented 2 years ago

@karthikeyad-pnnl : I merged the PR, but there is still a time event every 1 second:


Integration terminated successfully at T = 172800
   CPU-time for integration                  : 27.1451 seconds
   CPU-time for initialization               : 0.0245938 seconds
   Number of result points                   : 348702
   Number of grid points                     : 501
   Number of accepted steps                  : 58500
   Number of rejected steps                  : 3342
   Number of f-evaluations (dynamics)        : 91319
   Number of non-linear iteration            : 76804
   Number of non-linear convergence failures : 1
   Number of Jacobian-evaluations            : 3936
   Number of crossing function evaluations   : 235873
   Number of model time events               : 173333
   Number of state events                    : 783
   Number of step events                     : 0
   Maximum integration order                 : 5

SUCCESSFUL simulation of SystemModel.BoilerPlant.Validation.System

Can you reproduce this and correct it?