search

lbl-srg / obc

OpenBuildingControl - Performance Evaluation, Specification, Deployment and Verification of Building Control Sequences
http://obc.lbl.gov
26 stars 14 forks source link

Issue92 case study full hvac #120

Closed karthikeyad-pnnl closed 2 years ago

karthikeyad-pnnl commented 2 years ago

@mwetter : Hi Michael,

I found some additional instances of the unit delay block with sample periods of 1s. These were again being used to break algebraic loops. I have replaced all of them with integrator blocks. The number of model time events has been reduced by a factor of 100 (1113 events for a simulation period of 172800 seconds). The reference results remained unchanged for the controller (except for the 5 models for which I am getting discrepancies).

Please let me know if you still see events at frequent intervals.

Thanks, Karthik

image

mwetter commented 2 years ago

Thanks. I will look at it next week.

On Fri, May 13, 2022, 2:57 PM Karthik Devaprasad (PNNL) < @.***> wrote:

@mwetter https://github.com/mwetter : Hi Michael,

I found some additional instances of the unit delay block with sample periods of 1s. These were again being used to break algebraic loops. I have replaced all of them with integrator blocks. The number of model time events has been reduced by a factor of 100 (1113 events for a simulation period of 172800 seconds). The reference results remained unchanged for the controller (except for the 5 models for which I am getting discrepancies).

Please let me know if you still see events at frequent intervals.

Thanks, Karthik

[image: image] https://user-images.githubusercontent.com/59938817/168394560-bb1fafdc-806a-4314-a9a3-fd3459a128cd.png

You can view, comment on, or merge this pull request online at:

https://github.com/lbl-srg/obc/pull/120 Commit Summary

File Changes

(7 files https://github.com/lbl-srg/obc/pull/120/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/lbl-srg/obc/pull/120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKEPOB22YHKHE24I6GPRALVJ3F4DANCNFSM5V4SVHMA . You are receiving this because you were mentioned.Message ID: @.***>