Closed karthikeyad-pnnl closed 2 years ago
Thanks. I will look at it next week.
On Fri, May 13, 2022, 2:57 PM Karthik Devaprasad (PNNL) < @.***> wrote:
@mwetter https://github.com/mwetter : Hi Michael,
I found some additional instances of the unit delay block with sample periods of 1s. These were again being used to break algebraic loops. I have replaced all of them with integrator blocks. The number of model time events has been reduced by a factor of 100 (1113 events for a simulation period of 172800 seconds). The reference results remained unchanged for the controller (except for the 5 models for which I am getting discrepancies).
Please let me know if you still see events at frequent intervals.
Thanks, Karthik
[image: image] https://user-images.githubusercontent.com/59938817/168394560-bb1fafdc-806a-4314-a9a3-fd3459a128cd.png
You can view, comment on, or merge this pull request online at:
https://github.com/lbl-srg/obc/pull/120 Commit Summary
- 1a6db7e https://github.com/lbl-srg/obc/pull/120/commits/1a6db7e584f09ec3dac9a7f47d963af3d8d655ae Replaced logic that used unit delay with integrator for breaking algebraic loop
- 22f077a https://github.com/lbl-srg/obc/pull/120/commits/22f077aff8d7a6b3bfb429d714d6f1dfc8fe0e6a Updated unit test results
- f6f3d75 https://github.com/lbl-srg/obc/pull/120/commits/f6f3d75e89199b2861e81edf62adeda0afa99167 Updated formatting
- f96aa99 https://github.com/lbl-srg/obc/pull/120/commits/f96aa990933ea0bf75f655fe3a6651d5bdb2d73c Merge branch 'issue92_caseStudyFullHVAC_upstream' into issue92_caseStudyFullHVAC
- 24c057e https://github.com/lbl-srg/obc/pull/120/commits/24c057e0bdc342f540e4d897994467ce1a0fc549 Generated new reference results after merging latest upstream branch
File Changes
(7 files https://github.com/lbl-srg/obc/pull/120/files)
- M examples/case_study_4_fullHVAC/SystemModel/BoilerPlant/Submodels/BoilerPlantControls/Controller.mo https://github.com/lbl-srg/obc/pull/120/files#diff-92cd5099965b6870c15e895de96df9ca0d79cf9c509f5ab8a8d8912f17310814 (93)
- M examples/case_study_4_fullHVAC/SystemModel/Resources/ReferenceResults/Dymola/SystemModel_BoilerPlant_Submodels_BoilerPlantControls_Pumps_SecondaryPumps_Subsequences_Validation_EnableLag_pumpSpeed.txt https://github.com/lbl-srg/obc/pull/120/files#diff-06e23157c62b7d1e212a5ea23e6f0ddcf52c513bdb23aa2e67a01386a3b0ccd3 (4)
- M examples/case_study_4_fullHVAC/SystemModel/Resources/ReferenceResults/Dymola/SystemModel_BoilerPlant_Submodels_BoilerPlantControls_Staging_Processes_Subsequences_Validation_DisableBoiler.txt https://github.com/lbl-srg/obc/pull/120/files#diff-0115eeccb48279368fc18e6dc71c12e4cb6ed95b9640fd2b9498be5be63209f2 (4)
- M examples/case_study_4_fullHVAC/SystemModel/Resources/ReferenceResults/Dymola/SystemModel_BoilerPlant_Submodels_BoilerPlantControls_Staging_Processes_Validation_Up.txt https://github.com/lbl-srg/obc/pull/120/files#diff-de3126797ce4df510f3f84eb7fd0c661e417465168a2cbbb4e477535147c45f2 (62)
- M examples/case_study_4_fullHVAC/SystemModel/Resources/ReferenceResults/Dymola/SystemModel_BoilerPlant_Submodels_BoilerPlantControls_Staging_SetPoints_Subsequences_Validation_Change.txt https://github.com/lbl-srg/obc/pull/120/files#diff-639bbd03c2d06e01dd726063c3c8895e1f59b59d4be1e259441517a4c52b26a2 (14)
- M examples/case_study_4_fullHVAC/SystemModel/Resources/ReferenceResults/Dymola/SystemModel_BoilerPlant_Submodels_BoilerPlantControls_Validation_Controller.txt https://github.com/lbl-srg/obc/pull/120/files#diff-55d69be44ee7be17a7b47525301c29f8f19ad3a2a16f010739afb8fbe0b2c687 (4)
- M examples/case_study_4_fullHVAC/SystemModel/Resources/ReferenceResults/Dymola/SystemModel_BoilerPlant_Validation_System.txt https://github.com/lbl-srg/obc/pull/120/files#diff-2bead77b8740d5ee55a6a0b077596d84e1b54382b15907a85e9f469ec904d571 (12)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/lbl-srg/obc/pull/120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKEPOB22YHKHE24I6GPRALVJ3F4DANCNFSM5V4SVHMA . You are receiving this because you were mentioned.Message ID: @.***>
@mwetter : Hi Michael,
I found some additional instances of the unit delay block with sample periods of 1s. These were again being used to break algebraic loops. I have replaced all of them with integrator blocks. The number of model time events has been reduced by a factor of 100 (1113 events for a simulation period of 172800 seconds). The reference results remained unchanged for the controller (except for the 5 models for which I am getting discrepancies).
Please let me know if you still see events at frequent intervals.
Thanks, Karthik