search

lbl-srg / obc

OpenBuildingControl - Performance Evaluation, Specification, Deployment and Verification of Building Control Sequences
http://obc.lbl.gov
26 stars 14 forks source link

verify boiler control for case study #121

Closed mwetter closed 2 years ago

mwetter commented 2 years ago

For the case study, ensure that pumps start at minimum speed, and the boiler should likely also start at the minimum firing rate (of say 20 to 30%). Below is a plot that shows that these start with y=1:

image

Also, it looks incorrect that the boiler cycles, but is never operated at part load.

The figure was simulated with

simulateModel("SystemModel.Validation.System", stopTime=43200, method="Cvode", tolerance=1e-06, resultFile="System");

using commit 0e00d31ed75f6568058865c9b3047ae36e547fdf

mwetter commented 2 years ago

@karthikeyad-pnnl: can you please look into how to correct this and make a pull request.

karthikeyad-pnnl commented 2 years ago

@karthikeyad-pnnl: can you please look into how to correct this and make a pull request.

@mwetter : I have some ideas about how to change the logic. I will make the appropriate changes by the end of this week.

karthikeyad-pnnl commented 2 years ago

@mwetter : I have implemented changes to the logic to resolve the issues mentioned here. They have got coupled with some previous changes on PR #123. Please let me know if you would like me to submit these changes through a separate PR.

karthikeyad-pnnl commented 2 years ago

@mwetter: Can we close this issue since required changes have been merged into branch through commit?