search

lbl-srg / obc

OpenBuildingControl - Performance Evaluation, Specification, Deployment and Verification of Building Control Sequences
http://obc.lbl.gov
27 stars 14 forks source link

Issue83 point list #86

Closed JayHuLBL closed 3 years ago

JayHuLBL commented 4 years ago

This closes #83.

mwetter commented 4 years ago

@JayHuLBL : Thanks for the PR. I revised the wording, and added a "todo". Can you please make a proposal for how to address this "todo".

JayHuLBL commented 3 years ago

@mwetter Please see the updated specification regarding the point type propagation.

mwetter commented 3 years ago

@JayHuLBL : Can you please review my revisions and then we can discuss in our next meeting. I think the propagation rules became clearer this way. See also the comments in bold font for further suggested edits.

JayHuLBL commented 3 years ago

@mwetter I cleaned up the specification and left two comments.

mwetter commented 3 years ago

@JayHuLBL : Thanks for adding the need of multiple propagation declarations. Can you please see my revisions. I selected to allow multiple instances of propagate rather than an array in instance, and this will make it easier to change the value (if we had arrays, then a user would need to move items out the array and into another array). It will also avoid having to declare an array of only one element, which would probably be needed in many cases.

What remains to be done is to explain what the value of controlledDevice="Terminal unit" is, and how this is used. Currently, it is not used anywhere in the text and also not explained. Can you please address this so that all terms are explained, and only introduced if we need them.