Closed anandkp92 closed 2 years ago
@mwetter can you please review and suggest changes?
@anandkp92 Did you address everything and hence is this ready for review? If not, when do you plan to finish it?
@anandkp92 Did you address everything and hence is this ready for review? If not, when do you plan to finish it?
I have one more thing left to change (see shell=True comment above). I'm working on it now. Will try to get it fixed asap and close the commits by EOD today.
@mwetter its ready for your review now.
@anandkp92 : A few items before the merge:
MODELICAJSONPATH
needs to be set to in Readme file. Users won't know as this is not a standard environment variable.test
folder end to end. We could then integrate such a script in .travis.yml
. For omc, we have a docker at https://hub.docker.com/r/michaelwetter/ubuntu-2004-omc and a file to run it at https://github.com/lbl-srg/modelica-buildings/blob/master/Buildings/Resources/Scripts/travis/omc/omc.sh. This way, we know it works and have a state where we or users can reproduce how to run it.Hi @mwetter: I have addressed your comment regarding the unused variables and I believe it is ready to be merged now.
also added a readme file and test configuration