search

lbl-srg / obc

OpenBuildingControl - Performance Evaluation, Specification, Deployment and Verification of Building Control Sequences
http://obc.lbl.gov
27 stars 14 forks source link

Update building_medium_5A.idf #97

Closed yanchenpnnl closed 3 years ago

yanchenpnnl commented 3 years ago

This update changes the current one floor upper and lower boundary from "roof" and "ground" to "conditioned floor" and "zone/plenum" area. This is to approximate the heat transfer for a middle floor.

mwetter commented 3 years ago

@yanchenpnnl : Can you please correct the location to be Chicago. For example, there are various entries that seem to be for Buffalo:

https://github.com/lbl-srg/obc/pull/97/files#diff-f0ef114295bcdfee1b097bf6e5d89e5ca5ea28237d851074ff712ce3f3f630e5R63

https://github.com/lbl-srg/obc/pull/97/files#diff-f0ef114295bcdfee1b097bf6e5d89e5ca5ea28237d851074ff712ce3f3f630e5R74

https://github.com/lbl-srg/obc/pull/97/files#diff-f0ef114295bcdfee1b097bf6e5d89e5ca5ea28237d851074ff712ce3f3f630e5R83

Why is this needed if there is no ground coupling? https://github.com/lbl-srg/obc/pull/97/files#diff-f0ef114295bcdfee1b097bf6e5d89e5ca5ea28237d851074ff712ce3f3f630e5R101

Also, as we converge towards a final implementation it would be good to have only changes in the PR that are relevant. This has a lot of formatting (and maybe other?) changes that risk to hide potential errors that are introduced in revisions.