Recently (as of version 2.16.0), the @appuniversum/ember-appuniversum started using ember template-imports (https://github.com/ember-template-imports/ember-template-imports) and the .gjs/.gts syntax. While this is definitely the way forward for ember components, it introduces some challenges for this package.
The AuIcon component of the @appuniversum/ember-appuniversum package references svg icons externally. While this is a good approach for applications, it is less useful for packages like these where we want to inline the svgs (to remove the need of hosting the svg icons seperately).
Until recently, we could circumvent this issue by overwriting the appuniversum AuIcon in this package, this solution is no longer always possible with ember-template-imports (you can read https://rfcs.emberjs.com/id/0496-handlebars-strict-mode/ for more information about this).
The temporary solution in this PR is to downgrade the @appuniversum/ember-appuniversum package to version 2.15.0 until we find a more permanent solution.
Notice that the icons in the sidebar and link-editor are no longer missing.
Challenges/uncertainties
Downgrading the appuniversum dependency gives us time for a more permanent solution which will probably encompass adding svg-jar support to the appuniversum package.
Checks PR readiness
[x] UI: works on smaller screen sizes
[x] UI: feedback for any loading/error states
[x] Check cancel/go-back flows
[x] Check database state correct when deleting/updating (especially regarding relationships)
Overview
Recently (as of version 2.16.0), the
@appuniversum/ember-appuniversumstarted using ember template-imports (https://github.com/ember-template-imports/ember-template-imports) and the.gjs/.gtssyntax. While this is definitely the way forward for ember components, it introduces some challenges for this package.The
AuIconcomponent of the@appuniversum/ember-appuniversumpackage references svg icons externally. While this is a good approach for applications, it is less useful for packages like these where we want to inline the svgs (to remove the need of hosting the svg icons seperately).Until recently, we could circumvent this issue by overwriting the appuniversum
AuIconin this package, this solution is no longer always possible with ember-template-imports (you can read https://rfcs.emberjs.com/id/0496-handlebars-strict-mode/ for more information about this).The temporary solution in this PR is to downgrade the
@appuniversum/ember-appuniversumpackage to version 2.15.0 until we find a more permanent solution.connected issues and PRs:
GN-4731
How to test/reproduce
Challenges/uncertainties
Downgrading the appuniversum dependency gives us time for a more permanent solution which will probably encompass adding
svg-jarsupport to the appuniversum package.Checks PR readiness