lblod / frontend-embeddable-notule-editor

Frontend for an embeddable variant of the editor.
MIT License
1 stars 1 forks source link

GN-4845: Decision topic plugin #254

Closed dkozickis closed 4 months ago

dkozickis commented 4 months ago

Overview

See updated README - https://github.com/lblod/frontend-embeddable-notule-editor/blob/623e6f1dc90c92279b740c9ff4e39cb2385ed7bd/README.md#besluittopic-plugin

connected issues and PRs:

Setup

  1. Checkout
  2. pnpm run start

How to test/reproduce

See the README - https://github.com/lblod/frontend-embeddable-notule-editor/blob/623e6f1dc90c92279b740c9ff4e39cb2385ed7bd/README.md#besluittopic-plugin

Checks PR readiness

piemonkey commented 4 months ago

I forgot to mention in my review, the position in the toolbar of this, is for me, unusable. I had to edit the html in the inspector in order to remove the 2 toggles which pushed the control off the edge of the iframe. I don't think we need to fix that here, but we should really look at the toolbar improvements as a priority...

dkozickis commented 4 months ago

but we should really look at the toolbar improvements as a priority...

I think there is design time planned for this one