Update editor packages and related dependencies - Githubissues

lblod / frontend-embeddable-notule-editor

Frontend for an embeddable variant of the editor.

MIT License

1 stars 1 forks source link

Update editor packages and related dependencies #258

Closed elpoelma closed 2 months ago

elpoelma commented 3 months ago

Overview

Update of @lblod/ember-rdfa-editor to version 10.0.0. Note: this dependency update also includes dependency updates of other required packages.
Update of @lblod/ember-rdfa-editor-lblod-plugins to version 22.0.1
- Addition of the new article structure node.
- Removal of the classic decision prosemirror-nodes. These were no longer required and are now replaced by more generic RDFa nodes.

How to test/reproduce

Start the test-app
Notice that nothing breaks (all deps should load correctly)
The new decision article structure nodes should work as expected

Checks PR readiness

[x] UI: works on smaller screen sizes
[x] UI: feedback for any loading/error states
[x] Check cancel/go-back flows
[x] Check database state correct when deleting/updating (especially regarding relationships)
[x] changelog
[x] npm lint
[x] no new deprecations

elpoelma commented 3 months ago

For me this fails to start with a weird import error:
Error: Could not find module `@ember-data/model` imported from `(require)`
Trying to dig into it, I can only find that it's from when it tries to import the 'simple-editor' component. Not sure what's going on or why it's trying to find ember-data...

really weird... it doesn't even show up as a dependency when using pnpm why