search

lbolla / EMpy

Electromagnetic Python
MIT License
194 stars 83 forks source link

updated documentation to better reflect what epsfunc should do #11

Closed DavidRimel closed 7 years ago

DavidRimel commented 7 years ago

updated the documentation for what the epsfunc should do. As the old documentation i found the be incorrect.

lbolla commented 7 years ago

@DavidRimel Thanks for the PR. Can you please fix the issue highlighted above by Codacity and I'll be happy to merge your changes. Thanks!

DavidRimel commented 7 years ago

ok i fixed the issue and now my commits pass all the checks!

DanHickstein commented 7 years ago

Thanks for fixing my haphazard docstrings @DavidRimel! This makes it much easier to understand.

I noticed in your profile that you are from Boulder. I am also in Boulder, working at NIST and using EMPy to simulation the refractive index (and dispersion) of on-chip waveguides for supercontinuum generation.

lbolla commented 7 years ago

Thanks both!

DavidRimel commented 7 years ago

@DanHickstein thats awsome! im working at TechX using EMpy to solve for guided modes for our simulations of photonic devices such as micro ring resonators, arrayed wave guides, etc....

DanHickstein commented 7 years ago

Cool! We are also doing work with microring resonators. I didn't realize TechX was into that sort of thing - I thought that they were mainly plasma codes. I'd love to grab a coffee sometime and learn more about your research. Drop me an e-mail: danhickstein@gmail.com.