search

lbolla / EMpy

Electromagnetic Python
MIT License
194 stars 83 forks source link

EMpy installation downgrades matplotlib #23

Closed DanHickstein closed 5 years ago

DanHickstein commented 6 years ago

Currently, installing EMpy downgrades my matplotlib 2.0 to 1.5.x. Is there a reason that EMpy is not compatible with matplotlib 2.0?

In general, it seems weird that setup.py specifies maximum version numbers for the required packages. Typically, minimum version numbers are specified. (I.e., should the < signs be >?)

    install_requires=[
        'distribute>=0.6.28',
        'future<1.0dev',
        'numpy<2.0dev',
        'scipy<1.0dev',
        'matplotlib<2.0dev',
    ],
lbolla commented 6 years ago

It's normally safer to assume libraries to use "semver" and exclude the next major version which would include backward-incompatible changes. If, upon testing, version 2 works fine, we can unpin it. Happy to accept a PR.

Chronum94 commented 6 years ago

I ran it with matplotlib 2.2.0 and the tests/examples run fine. I'd send a PR, but I've made significant other changes to the code (none of which should break it, but I'm testing that).

lbolla commented 6 years ago

@Chronum94 thanks! Can you please make a single simple PR to upgrade matplotlib and a different PR for the other changes?

YagoDel commented 5 years ago

A bit late to the party, but just checked that everything works and made a simple PR. The only example that is a bit different is ex_RCWA.py and the scipy.linalg.linsolve is throwing a "LinAlgWarning: Ill-conditioned matrix [...] result may not be accurate"

lbolla commented 5 years ago

Unpinned all deps in master. Deps in requirement files are managed using pip-tools (see Makefile targets to bump them).