search

lbonn / i3-quickterm

A small drop-down terminal for i3 and sway
MIT License
128 stars 13 forks source link

Fix: change option for other terminals than urxvt #3

Closed cit closed 7 years ago

cit commented 7 years ago

I've changed my default terminal to termite, which had the consequence that i3-quickterm stopped working. I figured out that other terminals from urxvt want the arguments in different form. Same is true for gnome-terminal.

lbonn commented 7 years ago

Thanks! This is pretty annoying...

I tried several terminals: xterm and roxterm support both formats, xfce4-terminal and termite only the single arg, urxvt and st only the multiple args.

It would be nice to avoid defining an explicit list. An alternative would be to let the user set the argument method manually in the term config field (a bit like $@ and $* in bash/sh). I'll try to fix something.

lbonn commented 7 years ago

I changed my mind and added a list of common terminals (those I managed to test) with their correct format strings: 6649a7f2721bf90e5287dc1f83bd4e3dd1fd9dfe

This should resolve the issue. Also, you can now just set term to termite.