[REQUEST] window overview with images/icons

[ildar]

Before opening a feature request

• [X] I checked the next branch to see if the feature has already been implemented
• [X] I searched existing reports to see if it is already requested.

What is the user problem or growth opportunity you want to see solved?

Window overview show only XWayland windows' icons

rofi -show drun -show-icons

How do you know that this problem exists today? Why is this important?

rofi -show drun -show-icons

Window overview should show window images or icons.

Who will benefit from it?

Wayland users

Rofi version (rofi -v)

Version: 1.7.5+wayland2

Configuration

none

Additional information

any smart hint for this? Compositor: Hyprland.

[lbonn]

Just to clarify, you are talking about "window overview" but your description mentions a drun invocation. Did you mean rofi -show window -show-icons?

On sway, I have just tried it and it shows the firefox icon just fine even though it is a native wayland window.

Maybe it's an issue with hyprland not filling in the app_id in this case?

See the code here https://github.com/lbonn/rofi/blob/36621af0e49e1272fcafb161e1dbf0c1345b394f/source/modes/wayland-window.c#L597

[ildar]

Hi! thanks for answering.

On Wed, Dec 6, 2023 at 5:28 PM lbonn wrote:

Just to clarify, you are talking about "window overview" but your description mentions a drun invocation. Did you mean rofi -show window -show-icons?

true.

On sway, I have just tried it and it shows the firefox icon just fine even though it is a native wayland window.

Maybe it's an issue with hyprland not filling in the app_id in this case?

See the code here https://github.com/lbonn/rofi/blob/36621af0e49e1272fcafb161e1dbf0c1345b394f/source/modes/wayland-window.c#L597

not really. Hyprland seems to handle the app_id right though I'm no Wayland expert at all. Just see the screenshot below and this: https://github.com/hyprwm/Hyprland/commit/2cd2f8b5b5d7109577f9776996c6e7bc2713abdb

[ildar]