lbonn / rofi

Rofi: A window switcher, run dialog and dmenu replacement - fork with wayland support
Other
943 stars 37 forks source link

[BUG] Rofi being drawn under fullscreen window #12

Closed AndreaOrru closed 3 years ago

AndreaOrru commented 3 years ago

Version

Version: 1.6.0-49-g74a157c6 (makepkg)

Configuration

https://paste.debian.net/hidden/6d72e681/

Launch Command

rofi -show drun

Steps to reproduce

What behaviour you see

What behaviour you expect to see

Xyene commented 3 years ago

rofi draws on ZWLR_LAYER_SHELL_V1_LAYER_TOP, which renders under fullscreen views (https://github.com/swaywm/sway/pull/3057). I believe ZWLR_LAYER_SHELL_V1_LAYER_OVERLAY needs to be used to go over fullscreen views. mako for instance offers the layer as a config option.

The current behavior was added in https://github.com/lbonn/rofi/issues/7. (It's unclear to me how rofi can get triggered from the lockscreen, since the lockscreen should be capturing all input.)

lbonn commented 3 years ago

Thanks for the clarification, I suspected something like that. Not showing on top of full screen windows seems indeed worse than showing on top of lock screens, so I'll probably revert that.

Adding the layer as a config option is maybe another good approach.

lbonn commented 3 years ago

Reverted now

travankor commented 3 years ago

The current behavior was added in #7. (It's unclear to me how rofi can get triggered from the lockscreen, since the lockscreen should be capturing all input.)

rofi -show run &; sleep 1; swaylock Or wait for swayidle to lock while rofi is around.

See also: https://github.com/swaywm/swaylock/issues/107

Also, I believe wofi and bemenu have TOP as default. Otherwise, you could technically execute an arbitrary command while the launcher is focused (despite being locked).

markstos commented 3 years ago

I'm in favor of rofi appearing on top of full-screen apps.

With sway, you have to explicitly add --locked to a bindsym directive to allow a shortcut to launch an app on the lockscreen. I don't see anyone would set Rofi to be launched over the lockscreen. If they do, well then they explicitity meant to do that.