[REQUEST] Add a fix for icons path for main line Rofi.

musicfunfan commented 2 months ago

Before opening a feature request

[X] I checked the next branch to see if the feature has already been implemented
[X] I searched existing reports to see if it is already requested.

What is the user problem or growth opportunity you want to see solved?

In the main line Rofi there is a fix. I want that added to this fork. In order to have icons on the applications that do not have .png and the .svg extensions.

How do you know that this problem exists today? Why is this important?

I know this problem exist. Because i use the AM package manager for appimages. And the icons do not displayed on the Rofi. I did the research and find this issue.

Who will benefit from it?

I think all the people use packages that the icons do not have the file extensions will be benefit from this change.

Rofi version (rofi -v)

Version: 1.7.5+wayland2-1-gff2338c3

Configuration

My config files is here.

Additional information

I use archlinux. BTW

lbonn commented 2 months ago

@musicfunfan the fix commit you are referring to is present in the wayland branch (I've merged upstream changes a couple of days ago).

Maybe you can try it on a fresh build?

musicfunfan commented 2 months ago

I do not see an update on the AUR.

yay -Sua
:: Searching AUR for updates...
 -> Packages not in AUR: stacer
 there is nothing to do

Is it updated on A.U.R. ?

What do you mean with term "fresh build" ?

musicfunfan commented 2 months ago

So... i re-install the package this time form archrepo i did not know that this package was on the arch repo... But i have the same problem... Is there anything more i can try ? Did i do something wrong here?

If anyone knows something about this feel free to mention me. Thanks in advance. 😉

lbonn commented 2 months ago

@musicfunfan this package contains the latest released version, without this fix. If you really need a fix from the latest version on git and you are using AUR, this is probably what you are looking for: https://aur.archlinux.org/packages/rofi-lbonn-wayland-git

musicfunfan commented 2 months ago

Ok, yea i use A.U.R. This fix will included on the latest release ? If yes then i am happy to wait, because its not a big problem and i try when its possible not to use the A.U.R. when an official package exist. Just let me know if the A.U.R. (git package) will be the official package some day.

Anyway, thanks for the answer and your time.

lbonn / rofi