lbonn / rofi

Rofi: A window switcher, run dialog and dmenu replacement - fork with wayland support
Other
1.02k stars 42 forks source link

[WIP] Touch support #143

Open chayleaf opened 3 months ago

chayleaf commented 3 months ago

See #122

This implements touch support in the following way:

Maybe programmable gesture support should be added? this would be useful for e.g. mode switching. I have no idea how the config for that should look though.

in0ni commented 1 month ago

Moving discussion from #156 here, and will close according to authors responses.

@chayleaf, do you plan continuing work on this? I figured your PR was exactly that, a request to pull this into code base, and @lbonn has already expressed he would merge as an initial iteration.

Though it was not clear from this thread that this does not work as you state in 156... yes it's not perfect, but from my initial testing on two devices suffices to avoid having to replace rofi. There are some minor bugs, but at least it's functional and for me it greatly helps. Better this than having to look for another launcher.

If you can provide some feedback, I'm happy to help, or close the other PR -- just let me know :)

PS: duly noted regarding history/authorship, will do, thanks.

chayleaf commented 1 month ago

do you plan continuing work on this?

I am daily driving this branch on my phone, which is why I know it's not ready to merge yet. I do want to fix the issues when I have the time.

I figured your PR was exactly that, a request to pull this into code base

There is a reason this is a draft PR, draft PRs aren't ready for merging

For now, I recommend you to apply these patches locally.