search

lbonn / rofi

Rofi: A window switcher, run dialog and dmenu replacement - fork with wayland support
Other
943 stars 37 forks source link

[REQUEST] 1.7 release #24

Closed lokesh-krishna closed 3 years ago

lokesh-krishna commented 3 years ago

Rofi just released 1.7. Would be lovely to get it here as well.

lbonn commented 3 years ago

I've started merging back the changes. Please be patient, it should be ready in a week or two.

ram02z commented 3 years ago

Thanks for your work! If I may, can you release a proper tarball with all the code in the subprojects dir like upstream? This will make it much easier to package.

lbonn commented 3 years ago

1.7.0 is now merged in the wayland branch, you should be able to try it out. Please let me know if something is broken.

@ram02z: So far, I have not packaged this fork into releases / tarballs. I've created this issue to track this work https://github.com/lbonn/rofi/issues/25. Please continue this discussion there if needed.

tinywrkb commented 3 years ago

@lbonn any chance you could push the upstream tag, so the generated version of the AUR package (Arch Linux), created by git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g', will express that the build is based on the 1.7 release.

lbonn commented 3 years ago

Damn, I keep forgetting about that... Done!

tinywrkb commented 3 years ago

Thanks!

markstos commented 3 years ago

After upgrading, I see a couple problems.

  1. the icons appear tiny on my HiDPI screens. Maybe they aren't scaled
  2. The theme looks broken. This may be related to the change described in the Rofi changelog as changing how the default theme is loaded: https://newreleases.io/project/github/davatorium/rofi/release/1.7.0

Perhaps both issues have the same root cause related to whether the default theme was loaded or not: https://github.com/davatorium/rofi/releases/tag/1.7.0

The theming issue appears to be related to the upstream changes and not this fork. I'll try to resolve those through configuration and see it fixes the icon scaling issue at the same time.

markstos commented 3 years ago

I looked at this some and can't figure out. When I run rofi-theme-selector it's not scaled for HiDPI either-- it looks extra small. So I think the HiDPI issue may be a Wayland issue.

I read the rofi release notes and saw that the .Xresources configuration option has been removed. That removes an incompatibility with Wayland, which is good.

Also, the "Regolith Desktop" based on i3 used ".Xresources" to provide consistent theming throughout that desktop environment. Regolith will now have to find an alternative, also making it more compatibile with a switch to Sway/Wayland in the future. I could share my theme and configuration, but I don't think I have a screenshot of what it looked it before, so it will be hard to show the before/after change without downgrading this package, taking a screenshot and upgrading again.

lbonn commented 3 years ago

The theme changes definitely come from upstream, you should be able to find guidance in their release notes, pinned issues, discussions...

For the icon sizes, you can also change it in your theme. For example:

element-icon {
  size: 1.8ch;
}