search

lbonn / rofi

Rofi: A window switcher, run dialog and dmenu replacement - fork with wayland support
Other
983 stars 42 forks source link

[REQUEST] Building with autotools #32

Open lbonn opened 3 years ago

lbonn commented 3 years ago

Tracking issue in case we get to it.

jirutka commented 3 years ago

Is it actually worth it? Maybe better to remove this crap and keep only Meson.

lbonn commented 3 years ago

Good question, I have created the issue to launch the discussion.

That was also my opinion, mainly because I don't know a lot about autotools but maybe it's not that hard and we'd be better in sync with upstream.

mcepl commented 2 years ago

Sorry, for stealing this issue, but I don’t want to waste more on creating a separate thread. What are the plans for the future cooperation with the original rofi? I have packaged your repo for openSUSE, but now I don’t know what to do with the existing rofi? Do you plan to merge two project? Rename to something distinctive?

jirutka commented 2 years ago

Ahoj Matěji, the author of the original rofi previously stated that he didn’t wanna maintain support for Wayland, that’s why this fork exists and hasn’t been merged yet. IIRC, this was mentioned in a merge request in the original rofi repository.

I recommend packaging this fork under the name rofi-wayland, that’s what I did in Alpine Linux, where the following packages are provided:

keithbowes commented 10 months ago

Ahoj Matěji, the author of the original rofi previously stated that he didn’t wanna maintain support for Wayland, that’s why this fork exists and hasn’t been merged yet. IIRC, this was mentioned in a merge request in the original rofi repository.

My impression is that the issue was that there was no standard way to do the things needed by rofi in Wayland. This fork uses wlroots protocols and thus won't work well in GNOME, KDE, Weston, and other non-wlroots compositors

I recommend packaging this fork under the name rofi-wayland, that’s what I did in Alpine Linux, where the following packages are provided:

  • rofi – the original rofi, X11-only
  • rofi-themes – themes from the original rofi in a subpackage for both rofi and rofi-wayland
    • rofi-wayland – this fork, Wayland-only (built with -Dxcb=disabled)

I really don't get why there has to be two separate packages: one for X and one for Wayland. This fork seems to regularly merge upstream code, so it should be possible to use this fork without -Dxcb=disabled and have it so that it'll work in both X and Wayland. That said, Redhat seems to do what you describe. The distro I use doesn't even have the original rofi but Redhat RPMs usually tend to work with it (I basically stick with this distro instead of moving to one with more packages because I hate live/net installers, where it seems like all other distributions have gone to live/net installers (the distro I use has live and net installers but also allows the use of the "classic" installer I much prefer)).

About updating to build with autotools, no one has any problem with building with Meson. A lot of projects (including Wayland itself) are getting rid of their autotools-based build systems and only using Meson. Though, I do know of some things that have tried Meson and then went to cmake.