Initial support for wayland window switcher

lbonn / rofi

Rofi: A window switcher, run dialog and dmenu replacement - fork with wayland support

Other

927 stars 36 forks source link

Initial support for wayland window switcher #58

Closed alebastr closed 1 year ago

alebastr commented 1 year ago

Figured it's good enough to ask for initial feedback.

The following works:

Activate and Delete (close) actions
matching by window title
live update
icon lookup by app_id
window-format: {t} (title) and {a} (app_id, also mapped to {c} for compatibility)
window-match-fields: title and app-id (also mapped to class for compatibility)

The following does not (yet):

MENU_CUSTOM_ACTION — it can be supported and run something like wlrctl toplevel fullscreen "app_id:{a}" "title:{t}", but then we'll need to change config default based on the config.backend...
Icon lookup by the Icon= from {app_id}.desktop — ideally should reuse impl from drun.c, with cache and stuff, but that requires way more refactoring than I want to deal with. The logic in waybar's wlr/taskbar has been working quite well and could be used as an inspiration.

Fixes #57

lbonn commented 1 year ago

Thanks, it's looking quite good! I'll try to test it in a day or two.

lbonn commented 1 year ago

@alebastr it's working well and is probably in a state where we can already merge it before adding further improvements, what do you think?

alebastr commented 1 year ago

Sounds good to me, if you think it's in mergeable state please go ahead. Thanks!

Doing icon lookup from desktop files the right way seems pretty complex and I won't be able to work on it now anyways.

gibbz00 commented 1 year ago

Can't seem to find any community guidelines regarding allowed comments so I just wanted to take this opportunity to thank the both of you for your awesome work.

Installed this fork yesterday and had plans for today to look into the other window switching solutions. But seeing this pull request being getting merged during the night was such a pleasant suprise, made my day. Once again, big thanks to the unsung heroes of the open source community :)

justinesmithies commented 1 year ago

It works really well. One issue I have seen is qutebrowser it doesn't display it's icon as the helper cannot find it due to the actual name of qutebrowser being org.qutebrowser.qutebrowser . I discovered this and made a hacky work around to strip the org when I made a window switcher in Python for Qtile ( Wayland )

The error you get from your window switcher is (process:48455): Helpers.IconFetcher-WARNING **: 19:17:06.511: Failed to load image: Failed to open file “org.qutebrowser.qutebrowser”: No such file or directory