Make cursor more customizable

lbonn / rofi

Rofi: A window switcher, run dialog and dmenu replacement - fork with wayland support

Other

927 stars 36 forks source link

Make cursor more customizable #61

Closed vE5li closed 1 year ago

vE5li commented 1 year ago

This pull request aims to make cursor more customizable by adding cursor-width and cursor-color to the theme. This will allow the creation of block cursors such as this: block_cursor and also address issue #788.

From my point of view, the following things have to be done before this can be merged:

[x] Fix all current themes by adding the cursor-color property
[x] Properly format the updated code

If there is anything missing from that list, please let me know or update it directly.

vE5li commented 1 year ago

@lbonn I think that this is now ready to be merged

lbonn commented 1 year ago

@vE5li Did you try bringing up the idea upstream before? I would prefer not to deviate in backend-agnostic features if not necessary.

vE5li commented 1 year ago

I honestly didn't think about that. Sounds like a very good idea to me.

lbonn commented 1 year ago

Also for backward-compatibility, it would make sense that cursor-color should be deduced from text-color if not defined?

vE5li commented 1 year ago

Good point :) I'm not really sure how to do that properly but it would be much better.

vE5li commented 1 year ago

@lbonn I looked into it a bit and there seems to be no way of knowing if the color was found successfully, do you know of any way I could achieve this without making too many changes?