[BUG] The released tarball doesn't allow build (missing submodules)

[mcepl]

Rofi version (rofi -v)

1.7.1.-wayland1

Configuration

N/A

Theme

N/A

Timing report

N/A

Launch command

N/A

Step to reproduce

stitny~/b/h/rofi-wayland (4A)$ tar tvf rofi-1.7.1+wayland1.tar.gz|grep subproject
drwxrwxr-x root/root         0 2021-11-28 15:50 rofi-1.7.1-wayland1/subprojects/
drwxrwxr-x root/root         0 2021-11-28 15:50 rofi-1.7.1-wayland1/subprojects/libgwater/
lrwxrwxrwx root/root         0 2021-11-28 15:50 rofi-1.7.1-wayland1/subprojects/libgwater-wayland -> libgwater/wayland
lrwxrwxrwx root/root         0 2021-11-28 15:50 rofi-1.7.1-wayland1/subprojects/libgwater-xcb -> libgwater/xcb
drwxrwxr-x root/root         0 2021-11-28 15:50 rofi-1.7.1-wayland1/subprojects/libnkutils/
stitny~/b/h/rofi-wayland (4A)$ 

The tarball from https://github.com/lbonn/rofi/archive/refs/tags/1.7.5+wayland1.tar.gz doesn’t include content of the git submodules, which leads to:

[    4s] + /usr/bin/meson --buildtype=plain --prefix=/usr --libdir=/usr/lib64 --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin --includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man --infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc --localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload --auto-features=enabled . x86_64-suse-linux
[    4s] The Meson build system
[    4s] Version: 0.63.3
[    4s] Source dir: /home/abuild/rpmbuild/BUILD/rofi-1.7.1-wayland1
[    4s] Build dir: /home/abuild/rpmbuild/BUILD/rofi-1.7.1-wayland1/x86_64-suse-linux
[    4s] Build type: native build
[    4s] Project name: rofi
[    4s] Project version: 1.7.1+wayland1
[    4s] C compiler for the host machine: cc (gcc 12.2.1 "cc (SUSE Linux) 12.2.1 20221020 [revision 0aaef83351473e8f4eb774f8f999bbe87a4866d7]")
[    4s] C linker for the host machine: cc ld.bfd 2.39.0.20220810-1
[    4s] Host machine cpu family: x86_64
[    4s] Host machine cpu: x86_64
[    4s] Compiler for C supports arguments -Wparentheses: YES 
[    4s] Compiler for C supports arguments -Winline: YES 
[    4s] Compiler for C supports arguments -Wunreachable-code: YES 
[    4s] Compiler for C supports arguments -Werror=missing-prototypes: YES 
[    4s] Compiler for C supports arguments -Wno-inline: YES 
[    4s] Found pkg-config: /usr/bin/pkg-config (1.8.0)
[    4s] Run-time dependency glib-2.0 found: YES 2.74.0
[    4s] Run-time dependency gmodule-2.0 found: YES 2.74.0
[    4s] Run-time dependency cairo found: YES 1.17.6
[    4s] Library m found: YES
[    4s] Run-time dependency gio-unix-2.0 found: YES 2.74.0
[    4s] Run-time dependency pango found: YES 1.50.11
[    4s] Run-time dependency pangocairo found: YES 1.50.11
[    4s] Run-time dependency xkbcommon found: YES 1.4.1
[    4s] Run-time dependency gdk-pixbuf-2.0 found: YES 2.42.10
[    4s] 
[    4s] meson.build:62:0: ERROR: Subproject exists but has no meson.build file
[    4s] 

Expected behavior

Package builds just with the code from the tarball.

Actual behavior

It doesn’t (see above).

Additional information

meson-log.txt

[mcepl]

The problem is that git-archive doesn’t work with submodules so something more substantial must be used: e.g., I have now https://github.com/chrismaes87/git-archive-with-submodules installed.

[lbonn]

Tarballs generated by github don't contain submodules but releases include full tarballs generated and uploaded on CI.

For example https://github.com/lbonn/rofi/releases/download/1.7.1%2Bwayland1/rofi-1.7.1+wayland1.tar.gz for this version.

See #25

[mcepl]

Yes, thank you.