Closed mcepl closed 1 year ago
The changes are fine but could you re-title the commit to something descriptive and not a question?
About your question: I periodically pull from upstream to keep this fork in sync and usually recommend bringing up backend-agnostic changes / features to davatorium/rofi.
Finally about your patch, did you check if xdg-terminal
is available in most systems? It looks like it's been part of xdg-utils for a while but I don't see the executable in PATH on a Ubuntu 20.04 I have running:
$ xdg-<TAB>
xdg-dbus-proxy xdg-email xdg-open xdg-user-dir
xdg-desktop-icon xdg-icon-resource xdg-screensaver xdg-user-dirs-gtk-update
xdg-desktop-menu xdg-mime xdg-settings xdg-user-dirs-update
The situation is apparently even more complicated: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=604959 (note how old the bug is). So, I guess, using sane solutions and generally accepted ones is blocked here by Debian. Oh well.
Actually, that’s a serious question: do we?
I have here this patch and I am now considering where to send it: will you ever do sync with the upstream or is this fork final and we should send patches here?