search

lborgman / easy-cap-ed

For the captions editor EasyCapEd
0 stars 0 forks source link

Improve positioning of inline play button on Enter press #109

Closed MikeRidgway closed 6 years ago

MikeRidgway commented 6 years ago

When the user presses enter to be able to directly edit a word, don't move the play button relative to that word. Just leave it where it is in that instance.

lborgman commented 6 years ago

Why is that better?

MikeRidgway commented 6 years ago

I find it mentally jarring for the word I'm diving into to suddenly jump to the other side of the play button. I would expect it to stay exactly where it is when I go to edit it. It's like my brain then goes, "where'd it go? And then I look around and go, "Oh, there it is." :-)

lborgman commented 6 years ago

I see what you mean... But I am not sure what to do.

This will happen whenever you edit a word after a play button on the same row. There could be many words to change on a row, sometimes.

I have been planning for an option to not have any play buttons in the edit part, but instead have a play button at the bottom. Would that be a good alternative?

MikeRidgway commented 6 years ago

I think so.

On Mon, Jan 29, 2018 at 10:36 PM, lborgman notifications@github.com wrote:

I see what you mean... But I am not sure what to do.

This will happen whenever you edit a word after a play button on the same row. There could be many words to change on a row, sometimes.

I have been planning for an option to not have any play buttons in the edit part, but instead have a play button at the bottom. Would that be a good alternative?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lborgman/easy-cap-ed/issues/109#issuecomment-361474757, or mute the thread https://github.com/notifications/unsubscribe-auth/AED-sVruOtsnaXTCQLIOzRq2kyNIBNeTks5tPpxNgaJpZM4RbM2q .

lborgman commented 6 years ago

I am implementing this option, but it is not quite ready yet. On my way I decided to try to make the arrow removing less jarring by smoothly removing them. This is in 0.64.59. What do you think?

lborgman commented 6 years ago

I have added on option for this too.