search

lborgman / easy-cap-ed

For the captions editor EasyCapEd
0 stars 0 forks source link

Non-edit focus keeps moving to different words after video playback is paused #131

Closed MikeRidgway closed 6 years ago

MikeRidgway commented 6 years ago

... making it kind of hard to edit the word that you intended to edit as the keystroke you press will be applied to a different word by the time you press it.

lborgman commented 6 years ago

Thanks @MikeRidgway , it looked like I stopped at the wrong place. I think I fixed it now (0.64.75).

Do you still see it?

lborgman commented 6 years ago

Hm, the bug is still there.

lborgman commented 6 years ago

But now it might be mostly gone. (I'm still hesitating to implement an FSM for this. Too many states. I must be thinking wrong somehow. 🤔)

lborgman commented 6 years ago

Hm, no. When I tested an hour ago it worked fine on my mobile, but now"play word" doesn't always start as it should. So there is a timing issue.

lborgman commented 6 years ago

Maybe I should say that at the bottom of this problem is the fact that the YouTube video player does not tell you when it has moved to the time you requested. So you have to loop and check to find out when it is ready. However this creates performance problems on a mobile if you do it too fast. And a bad UI if you do it too slow.

MikeRidgway commented 6 years ago

Yes, my software has to use similar functionality. A perpetual check to see if a time point in the video has been reached.

On Sun, Feb 4, 2018 at 10:09 AM, lborgman notifications@github.com wrote:

Maybe I should say that at the bottom of this problem is the fact that the YouTube video player does not tell you when it has moved to the time you requested. So you have to loop and check to find out when it is ready. However this creates performance problems on a mobile if you do it too fast. And a bad UI if you do it too slow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lborgman/easy-cap-ed/issues/131#issuecomment-362918324, or mute the thread https://github.com/notifications/unsubscribe-auth/AED-sTYmmB4WFCCQQeKyP15RJAGPxDMcks5tRdY4gaJpZM4R2c5r .

lborgman commented 6 years ago

I think this is fixed now. It should be pretty stable. (Though there is one issue with starting to play word while already playing word. It should just restart playing the same word.)