lbr-stack / fri

CMake support for KUKA's FRI Client SDK
Apache License 2.0
15 stars 17 forks source link

[JOSS Review] Repository License Issues #17

Closed CameronDevine closed 8 months ago

CameronDevine commented 8 months ago

As part of the JOSS review, openjournals/joss-reviews#6138, this repository needs to have an OSI approved license. While this repository does have a license listed, I am worried about the license issues of including the KUKA FRI SDK in this repository.

This also appears to be related to #6 and #14. Please fix this issue using at least one of the methods suggested in your existing issues.

mhubii commented 8 months ago

hi @CameronDevine , just saw your first reviews. Thank you very much, I really appreciate it! Will try to fix those, so we can improve this software :)

mhubii commented 8 months ago

Putting for reference https://joss.readthedocs.io/en/latest/review_criteria.html#software-license

mhubii commented 8 months ago

added notice https://github.com/lbr-stack/fri/blob/fri-1.15/NOTICE