search

lbr-stack / pyfri

KUKA Fast Robot Interface Python SDK.
https://lbr-stack.readthedocs.io/en/latest/pyfri/doc/pyfri.html
Apache License 2.0
22 stars 3 forks source link

Add Automated Build/Tests #14

Open CameronDevine opened 7 months ago

CameronDevine commented 7 months ago

As part of the JOSS review (openjournals/joss-reviews#6138) I think this repository should have an automated build, preferably with some tests.

mhubii commented 6 months ago

agreed, thank you for the feedback!

mhubii commented 4 months ago

I will try to find time to work on this soon. Any chance you could help out here a little @cmower? Or are you too occupied? No worries if not.

mhubii commented 2 months ago

automatic builds are already added for Ubuntu 24.04 and 22.04. Currently missing are tests

CameronDevine commented 2 months ago

I think automated builds alone should be sufficient as this repository primarily contains bindings.

mhubii commented 2 months ago

thanks for the feedback @CameronDevine, I am in the process of writing an emulator for the robot to mimic its behavior. This should allow for simple testing by the end of the week.

mhubii commented 1 month ago

maybe in the interest of time, is it possible to treat the procedural tests with virtual hardware separately from this review? I would then open new issues and reference this but keep JOSS untagged.

The progress of the emulator can be tracked here : https://github.com/lbr-stack/fri_emulator

CameronDevine commented 1 month ago

I don't think closing this issue is required for me to recommend acceptance. @adi3 is this correct?