Can't pull complete EU players stats

lbrictson / pypubg

A thin client for calling the player unknown battleground stat tracker api

MIT License

27 stars 13 forks source link

Can't pull complete EU players stats #10

Open TheChosenZygote opened 7 years ago

TheChosenZygote commented 7 years ago

EU players who try to pull their stats are not able to.

For example, api.player_mode_stats("housjeee") only returns asian solo games stats.

lbrictson commented 7 years ago

Shall look into this hopefully tomorrow

jeffreyleeon commented 7 years ago

@TheChosenZygote Currently if you don't pass game_mode and game_region keys into the function api.player_mode_stats. Default game_mode will be default as 'solo' and game_region will be default as 'asia'.

@lbrictson A better design is to give a wildcard to return all if no value is given from developer.

I can help developing this feature.

jeffreyleeon commented 7 years ago

@TheChosenZygote Your request is addressed here (https://github.com/lbrictson/pypubg/pull/11). Waiting for merge approval.

But if you want to try it now, I recommend you to use library from my repository. (https://github.com/jeffreyleeon/pypubg)