search

lbruun-net / Pre-Liquibase

Spring Boot add-on to Liquibase
Apache License 2.0
49 stars 9 forks source link

Are there any plans to make this lib work with Spring boot 2.5.x? #1

Closed neev-dev closed 3 years ago

neev-dev commented 3 years ago

Hi,

Thanks for coming up with this library as it solves a tricky issue elegantly. Just wanted to know if there are any plans to make this work for Spring Boot 2.5.x.

There seems to be change in LiquibaseConfiguration::liquibase() method's signature in 2.5.x (https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfiguration.LiquibaseConfiguration.html) which causes the following failure.

Thank you.

Description:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

net.lbruun.springboot.preliquibase.PreLiquibaseAutoConfiguration$DefaultPreLiquibaseDataSourceProvider.<init>(PreLiquibaseAutoConfiguration.java:229)

The following method did not exist:

'liquibase.integration.spring.SpringLiquibase org.springframework.boot.autoconfigure.liquibase.LiquibaseAutoConfiguration$LiquibaseConfiguration.liquibase(org.springframework.boot.autoconfigure.jdbc.DataSourceProperties, org.springframework.beans.factory.ObjectProvider, org.springframework.beans.factory.ObjectProvider)'

The method's class, org.springframework.boot.autoconfigure.liquibase.LiquibaseAutoConfiguration$LiquibaseConfiguration, is available from the following locations:

jar:file:/Users/neevdev/.m2/repository/org/springframework/boot/spring-boot-autoconfigure/2.5.0/spring-boot-autoconfigure-2.5.0.jar!/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfiguration$LiquibaseConfiguration.class

The class hierarchy was loaded from the following locations:

org.springframework.boot.autoconfigure.liquibase.LiquibaseAutoConfiguration.LiquibaseConfiguration: file:/Users/neevdev/.m2/repository/org/springframework/boot/spring-boot-autoconfigure/2.5.0/spring-boot-autoconfigure-2.5.0.jar
lbruun commented 3 years ago

Thanks for reporting.

I must admit it doesn't come as a total surprise. I've read about the significant changes in the area of datasource auto config in Spring Boot 2.5 and had it on my radar that it would probably break PreLiquibase.

I'll have a look. Allow a few days. What takes a little time is figuring out if I can support v2.1 - 2.4 with the same code base as >= v2.5.

lbruun commented 3 years ago

Issue with Spring Boot 2.5 compatibility is now fixed in release 1.1.0 which currently is in progress of being sync'ed to Central Maven. (can take up to 2 hours, check here to see if available)

Also the README has been updated with information about Spring Boot compatibility.