search

lbruun-net / Pre-Liquibase

Spring Boot add-on to Liquibase
Apache License 2.0
49 stars 9 forks source link

Handle AutoCloseable connexion and database #9

Closed zorglube closed 1 year ago

zorglube commented 2 years ago

Can't be merge until Liquibase didn't release this PR https://github.com/liquibase/liquibase/pull/2990 related to the issue https://github.com/liquibase/liquibase/issues/2974

zorglube commented 2 years ago

Normally the next Liquibase release will include AutoCloseable interface.

zorglube commented 2 years ago

Still have to waite for the next Liquibase release.

lbruun commented 2 years ago

Still have to wait for the next Liquibase release.

It is not only about when this is released by the Liquibase project. More so it is a matter of when the Spring project updates their dependency version on Liquibase.

zorglube commented 2 years ago

Still have to wait for the next Liquibase release.

It is not only about when this is released by the Liquibase project. More so it is a matter of when the Spring project updates their dependency version on Liquibase.

You're definitely right ;-)

zorglube commented 2 years ago

Have to wait for a version of liquibase upper than https://github.com/liquibase/liquibase/releases/tag/v4.14.0

lbruun commented 1 year ago

Hi @zorglube. The project has been updated to use Spring Boot 3. This means that it now implicitly uses Liquibase 4.17.2 where your Liquibase PR is included. In other words: I think this PR can now proceed.

A fair amount of changes has happened in the mean time on Pre-Liquibase. Therefore, this PR needs to re-based. Thx.

zorglube commented 1 year ago

Ok, I'll have a look next week.

zorglube commented 1 year ago

Hello @lbruun ,

I'm definitely not sure of my rebase, please be carfull before merge.

zorglube commented 1 year ago

Close in the benefit of : https://github.com/lbruun/Pre-Liquibase/pull/19