search

lbryio / aioupnp

UPnP for asyncio
MIT License
29 stars 7 forks source link

Faster gateway discovery #18

Closed jackrobison closed 5 years ago

jackrobison commented 5 years ago

Previously the required pattern for the M-SEARCH packet was probed out by sending two variants at a time, and then each on their own once a pair had a hit. This changes device discovery to try all of the variants at once. This means discovery will be much faster, but it is not possible to know which packet variant was needed versus the others.

codecov[bot] commented 5 years ago

Codecov Report

Merging #18 into master will increase coverage by 0.16%. The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   92.77%   92.94%   +0.16%     
==========================================
  Files          18       18              
  Lines        1371     1360      -11     
==========================================
- Hits         1272     1264       -8     
+ Misses         99       96       -3
Impacted Files Coverage Δ
aioupnp/__main__.py 91.02% <ø> (-2.65%) :arrow_down:
aioupnp/serialization/ssdp.py 94.8% <100%> (+0.1%) :arrow_up:
aioupnp/upnp.py 85.18% <100%> (+0.89%) :arrow_up:
aioupnp/protocols/scpd.py 98.24% <100%> (ø) :arrow_up:
aioupnp/protocols/ssdp.py 100% <100%> (+4.65%) :arrow_up:
aioupnp/gateway.py 84.65% <68.62%> (-1.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1c39ce...8e07d7f. Read the comment docs.