search

lbryio / aioupnp

UPnP for asyncio
MIT License
29 stars 7 forks source link

Fix unclean exit due to uncaught errors/exceptions #5

Closed hackrush01 closed 5 years ago

hackrush01 commented 5 years ago

This is done to prevent python spewing out "Task exception not retrieved" as asyncio.wait() doesn't consume tasks... Also small fix, to pass unicast to _discover_gateway if set

codecov[bot] commented 5 years ago

Codecov Report

Merging #5 into master will increase coverage by 0.09%. The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   82.46%   82.55%   +0.09%     
==========================================
  Files          26       26              
  Lines        1796     1811      +15     
==========================================
+ Hits         1481     1495      +14     
- Misses        315      316       +1
Impacted Files Coverage Δ
tests/test_cli.py 100% <100%> (ø) :arrow_up:
aioupnp/upnp.py 45.66% <100%> (ø) :arrow_up:
tests/test_gateway.py 97.43% <100%> (+1%) :arrow_up:
aioupnp/gateway.py 75.14% <77.77%> (-0.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19e87e8...ca5ff5f. Read the comment docs.