search

lbryio / block-explorer

The new LBRY block explorer
https://explorer.lbry.com
MIT License
18 stars 22 forks source link

# of confirmations not calculated correctly #57

Open tzarebczan opened 5 years ago

tzarebczan commented 5 years ago

It shows 1 confirmation on block and transaction pages.

tzarebczan commented 5 years ago

@akinwale / @nikooo777 you think you'd be able to take a look at this one soon? Community members are noticing it as well.

tiger5226 commented 5 years ago

So we no longer keep old transactions that are not included in the leading chain. They are cleared. So technically we only have to take current height or max block height and subtract the height of the block in question. I have this in my @tzarebczan if they cannot get to it. I should have the ppv completed tonight. So I can probably make this one the next highest priority.

tzarebczan commented 5 years ago

Looks like we had a fix, which worked for some, but if you look at https://explorer.lbry.com/address/bSSfLmehtc3PsDoj1ZDNmYkTbrNiTPj2CW the confirmations are not shown correctly on the top blocks.

tiger5226 commented 5 years ago

Also the block page does show the right confirmation. Its just this list apparently.

akinwale commented 5 years ago

The old fix from https://github.com/lbryio/block-explorer/commit/667097f35d81e034b3130a5032d8f05461677b10#diff-84d5d8e3196d5767f5a47b5871946dddR598 can be adapted for this.

Essentially, we just need to obtain the max block height and then subtract the height of the corresponding transaction from the max height.