lbryio / lbcd

An alternative full node implementation of LBRY's blockchain written in Go (golang)
https://lbry.com/
ISC License
39 stars 26 forks source link

Increase wire.MaxBlockPayload to 8MB #19

Closed roylee17 closed 2 years ago

roylee17 commented 2 years ago

This variable seems redundant to the blockchain.MaxBlockBaseSize to make the wire and blockchain self-contained. We've updated the blockchain.MaxBlockBaseSize to 8MB for LBRY, but missed this one?

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1804753474


Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 76.16%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 1782808406: 0.02%
Covered Lines: 22327
Relevant Lines: 43084

💛 - Coveralls
BrannonKing commented 2 years ago

This PR has the fee functions as well; that doesn't seem quite right. As for the maximum block size, your change looks correct: https://github.com/lbryio/lbrycrd/blob/master/src/consensus/consensus.h