lbryio / lbcd

An alternative full node implementation of LBRY's blockchain written in Go (golang)
https://lbry.com/
ISC License
39 stars 26 forks source link

mining: always returns .coinbasevalue in getblocktemplate #97

Closed roylee17 closed 2 years ago

roylee17 commented 2 years ago

Fix #96

Although the BIPs specify that coinbasetxn and coinbasevalue are mutually exclusive, both the latest bitcoind (22.0.0) and lbrycrd (0.17.3) returns .coinbasevalue regardless if 'coinbasetxn' is specified in the capabilities.

We'll make lbcd behave the same for compatibility.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 3124530091


Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 2 0.0%
<!-- Total: 0 2 0.0% -->
Files with Coverage Reduction New Missed Lines %
rpcserver.go 1 0.26%
btcec/signature.go 3 92.82%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 3116809343: 0.001%
Covered Lines: 22476
Relevant Lines: 43930

💛 - Coveralls