coveralls
commented
2 years ago Pull Request Test Coverage Report for Build 3252072246
- 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
- 14 unchanged lines in 3 files lost coverage.
- Overall coverage decreased (-0.02%) to 51.101%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| rpcclient/infrastructure.go | 0 | 4 | 0.0% | ||
| <!-- | Total: | 0 | 4 | 0.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| integration/rpctest/blockgen.go | 2 | 83.78% | ||
| btcec/signature.go | 3 | 92.82% | ||
| peer/peer.go | 9 | 75.92% | ||
| <!-- | Total: | 14 | --> |
| Totals | |
|---|---|
| Change from base Build 3200324786: | -0.02% |
| Covered Lines: | 22494 |
| Relevant Lines: | 44019 |
in the case where you're e.g. trying to connect to an invalid address, the err vars in
handleSendPostMessage()were being shadowed inside the for loop. ifc.httpClient.Do()returned an error, that error never got returned upstream. thenioutil.ReadAll(httpResponse.Body)would get a nil pointer dereference.this fixes that case.