lbryio / lbry-android

The LBRY Android app
MIT License
2.44k stars 113 forks source link

Hide support button and comments consistently with claim tags #1152

Closed kekkyojin closed 3 years ago

kekkyojin commented 3 years ago

PR Checklist

Please check all that apply to this PR using "x":

PR Type

What kind of change does this PR introduce?

Fixes

Issue Number:1146

What is the current behavior?

See #1146

What is the new behavior?

See #1146

Other information

In comment fragment for channel, the comment form visibility is GONE to avoid it been shown just before being replaced by the texto for channels having comments disabled. This change is not needed for FileViewFragment as this replacement occurs while not in user view.

Two new strings have been added. Text was taken from LBRY.TV. Translation will be needed.

This commit adds code to code which is already been duplicated in various files. This will be fixed in an upcoming PR which replaces comment form with a new widget instead of a layout which should be

kekkyojin commented 3 years ago

Known problem: on content view, the text explaining that comments have been disabled by the author, wallet and rewards bubble is positioned just above it, so the string is not visible on its full length. It will fixed for #1054 very shortly.