Update strings.xml - Githubissues

lbryio / lbry-android

The LBRY Android app

MIT License

2.44k stars 113 forks source link

Update strings.xml #1161

Closed sahelea1 closed 3 years ago

sahelea1 commented 3 years ago

Optimized translations. Unified Strings to non formal Salutation.

PR Checklist

Please check all that apply to this PR using "x":

[X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[X] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[X] Other - Please describe: Language Pack Optimization
Fixes

Issue Number:

What is the current behavior?

Different salutations on different strings. Some things arent translated correctly.

What is the new behavior?

Translated Correctly.

Other information

kauffj commented 3 years ago

Hey @sahelea1, thanks for doing this. Unfortunately these live in another system (Transifex) and this file merely pulls them from there, so we cannot commit this file. If you'd like to join us as a translator, can you email me at jeremy@lbry.com? Thanks!