search

lbryio / lbry-android

The LBRY Android app
MIT License
2.44k stars 113 forks source link

User is offered to be verified while its status is in Reward Approval Pending #1167

Open kekkyojin opened 3 years ago

kekkyojin commented 3 years ago
## The Issue ### Steps to reproduce 1. Verify email address 2. Verify account with Twitter or Phone Number 3. Open Rewards activity ### Expected behaviour User should be informed its account is pending approval for rewards ### Actual behaviour User sees the same page as it is net yet been verified, allowing it to "Get Started" -verify wil Twitter, Phone Number or paying the fee- or go back. This is both confusing for user who has yet ben verified and resource consuming for LBRY, as more verification requests would be performed to its servers because of user's confussion. ## Internal Use ### Acceptance Criteria 1. 2. 3. ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [ ] Documentation updated - [ ] Peer Code Review performed
tzarebczan commented 3 years ago

Phone pending should work (or used to), and it should show them a splash screen about pending. Twitter may not, but that would be a bug on the api side which probably doesn't set the is_verified flag.