Hide floating wallet on the Channel fragment

lbryio / lbry-android

The LBRY Android app

MIT License

2.44k stars 113 forks source link

Hide floating wallet on the Channel fragment #1177

Closed kekkyojin closed 3 years ago

kekkyojin commented 3 years ago

PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

[x] Bugfix

Fixes

Issue Number: #1054

What is the current behavior?

What is the new behavior?

Floating wallet will disappear on About and Comment tabs on the Channel fragment

kekkyojin commented 3 years ago

Yesterday at night I realized that I had to unrefister the callback for the viewpager. This new commit changes code so it is done when user exits the channel fragment. The unregister method needs to get the callback class, so it has been to be changed from anonymous to a regular instance of the class.

I am re-requesting a review because the new code seems a little bit different, although it is just because of the fact it is no longer using an anonymous object for the callback.