lbryio / lbry-android

The LBRY Android app
MIT License
2.43k stars 113 forks source link

Don't show link to Bittrex #1181

Closed kekkyojin closed 3 years ago

kekkyojin commented 3 years ago

This fix uses two services:

This way users not on North-America won't see their IPs sent to a third-party provider.

PR Checklist

Please check all that apply to this PR using "x":

PR Type

What kind of change does this PR introduce?

Fixes

Issue Number: #1179

What is the current behavior?

For IPs on the US, users are shown a message about using Bittrex to exchange LBRY Credits to USD. Bittrex is no longer allowing that for users in the US, but LBRY Android users are going to see the message

What is the new behavior?

Message is not being shown

Other information

By default, the message is not shown. Then, depending on the IP of the user, it is programmatically made visible. Network requests are using Java Future, because AsyncTask is now deprecated and Java Future works on all supported Android API levels.