lbryio / lbry-android

The LBRY Android app
MIT License
2.44k stars 113 forks source link

Added QR scanner to wallet send card #1194

Closed patrickbunetic closed 3 years ago

patrickbunetic commented 3 years ago

PR Checklist

Please check all that apply to this PR using "x":

PR Type

What kind of change does this PR introduce?

Fixes

Issue Number: #202

What is the current behavior?

There is no QR scanner for sending funds to an address encoded as a QR code.

What is the new behavior?

In the Wallet's Send card, there is now QR scanning functionality which will fill the recipient address with the value the scanner gets.

Other information

The QR library (zxing 4.1.0) works on SDK 24 and up, but I added a 'fallback' for 3.3.0 as they advise so the minimum SDK of 21 should still work and be able to use the functionality. I was not, however, able to test this on any devices with that SDK version.

tzarebczan commented 3 years ago

Thanks so much for the PR! We'll get another closer review on it soon.

Can we show you some appreciation?