I extracted dimension values into resource files #1151.

veritaslogix commented 3 years ago

(https://github.com/lbryio/lbry-android/issues/1151)

Hi there! Because a lot of dimensions get reused, when I moved the dimensions file I used names like "large_1", "small_1", and "normal_1" for dimension values.

I tried this to cut down on repetitive values in the dimens file.

"small" values range between 0dp and 15dp "normal" values range between 16dp to 119dp "large" values are anything over 120dp (the largest is 480dp)

[PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.]

PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ ] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[x] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes

Issue Number: 1151

What is the current behavior?

What is the new behavior?

Other information

kekkyojin commented 3 years ago

For the next time, I suggest you to use a new branch for yout changes instead of commiting to your master branch

veritaslogix commented 3 years ago

Okay, thanks!

lbryio / lbry-android