search

lbryio / lbry-android

The LBRY Android app
MIT License
2.43k stars 113 forks source link

Always overwrite subs/tags from sync #855

Closed tzarebczan closed 4 years ago

tzarebczan commented 4 years ago

There's a scenario on Android where we merge tags/subs after a sync from previous redux/local state. This will cause channels to re-appear if they are removed from lbry.tv and then later Android syncs again

Repro: Remove a channel from lbry.tv refresh Android app, channel still exists Follow a new channel previously removed channel is synced back

tzarebczan commented 4 years ago

Part of the confusion looks like this is coming from us grabbing sub data from apis (https://github.com/lbryio/lbryinc/blob/master/src/redux/actions/subscriptions.js#L323). We don't do this on Desktop/lbry.tv - we should consider removing it.

The other half is android storing some redux state for subs and not overwriting it when a channel is removed from lbry.tv.

tzarebczan commented 4 years ago

@akinwale this is still and issue and causes unfollowed channels to come back when a user uses both mobile + other apps. A bunch of users are having trouble with it.

If you unfollow on Android, it works, but if you unfollow on another app, and then android syncs, it just syncs it back.