lbryio / lbry-android

The LBRY Android app
MIT License
2.43k stars 113 forks source link

Crash when Reposting with a 0 LBC Stake and no Channel Selected #905

Open cahlenlee opened 4 years ago

cahlenlee commented 4 years ago

DESCRIPTION:

Attempting to Repost a video with a 0 LBC Stake and no Channel selected results in a Crash.


REPRO STEPS: 1) Install and Launch LBRY 0.15.6 on Android 9 2) Navigate to 'Menu > All Content' 3) Select any video 4) Select 'Repost' 5) Select 'Show Advanced' 6) Change 'Deposit' to 0.000 7) Select 'Repost'

Results: Crash

Expected: Error appears


ENVIRONMENT:


MEDIA:

etc-1500


INTERNAL USE:


DEFINITION OF DONE:


LBRY ADDRESS: bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b mail@cahlen.org

kekkyojin commented 4 years ago

If reposting to a channel is a requirement, then the Repost button shouldn't be available. Then, I suggest validating the stake and showing a toast if the amount is not high enough.

clay53 commented 4 years ago

@kekkyojin Doesn't look like it image Maybe just allow anonymous reposts then.

kekkyojin commented 4 years ago

This was fixed on commit 40c36df4 and 4a3db5ae.

Trying to reproduce this bug on latest available source code 0.15.14 ends with a error message toasted on the bottom part of the device screen. When user is already signed on, the reposting channel is pre-selected and cannot be changed, so reported problem cannot be reproduced, neither.

Could you update LBRY Android to latest release and check this, @cahlenlee? Thank you.

cahlenlee commented 4 years ago

This no longer reproduces in 0.15.14. Appropriate error messages appear if value is set to 0, or if user tries to submit a non-zero value with no channel selected.

cahlenlee commented 3 years ago

No Longer Occurs on 0.16.11. Recommend Closing.