Setup never completes or times out with no internet connection

cahlenlee commented 4 years ago

DESCRIPTION:

Setup never completes or times out with no internet connection.

REPRO STEPS: 1) Disconnect from the Internet 2) Install and Launch LBRY 0.16.0 on Android 8.1.0

Results: Setup screen persists indefinitely

Expected: Error appears stating internet connection is required

ENVIRONMENT:

LG V20
Android 8.1.0
LBRY 0.16.0

MEDIA:

Screenshot_20200821-155947_LBRY

INTERNAL USE:

DEFINITION OF DONE:

[ ] Tested against acceptance criteria
[ ] Tested against the assumptions of the user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

LBRY ADDRESS: bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b mail@cahlen.org

ycohen-dev commented 3 years ago

I'm wondering how to even implement it. If time measurement is done within the first run activity, how do we account for the user leaving the app and returning while not completing the aforementioned activity? How do we keep in sync the "wait for sdk ready message" with "...but not if 2 min passed"

akinwale commented 3 years ago

First run no longer requires sdk to be ready, but an Internet connection is still required for other operations.

cahlenlee commented 3 years ago

This appears to be fixed in 16.11

lbryio / lbry-android

Setup never completes or times out with no internet connection #986