lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 413 forks source link

Meaningfully Styled URLs #2135

Open QuirkyRobots opened 5 years ago

QuirkyRobots commented 5 years ago

As someone that is very UX/UI focused, I thought it would be a good idea to have the different parts of the URL more apparent than others. The permanent part of the URL is not something that needs to be seen. Making it less obvious with an opacity reduction would make the whole URL look more attractive and more obvious what it points to.

The channel part of a URL (not shown) could also have a slight colour adjustment, such as a LBRY shade of green, to help a user identify that part and help make the URL more meaningful.

More crazy ideas from me, but what would the world be without crazy people! 😭

Normal Style: Looks messy and confusing.

lbryapp2

Meaningful Style: Looks pleasing and informative.

lbryapp1

neb-b commented 5 years ago

@Invariant-Change This is a great idea!

tzarebczan commented 5 years ago

1) The permanent part is necessary because of how vanity URLs work. I don't think not shading it is the answer. This will be solved with https://github.com/lbryio/lbry/issues/958

2) We aren't showing channel URLs on most claims do to some bugs on how they are resolved if there are duplicates.

QuirkyRobots commented 5 years ago

Yes, they are necessary, but they are also ugly and get in the way of the useful vanity URL. In this example, you can still see the permanent URL and it's still fully functional, but the less obvious style of it gives the whole URL more meaning and aesthetics. Visual ergonomics! My crazy creative mind loves it. lol

neb-b commented 5 years ago

~I think we should still show the full url. If we show the vanity url and a user tries to copy that, the person they share it wil may be directed to a different claim.~

I misunderstood that issue. I still think this would be a good change. It puts more emphasis on the name, no one cares about the claim id

It's also common in browsers:

screen shot 2018-12-05 at 12 21 03 am
QuirkyRobots commented 5 years ago

I'm trying to digest how a URL will look with the new approach on https://github.com/lbryio/lbry/issues/958 so can't comment on that part atm. I might need another coffee!

kauffj commented 5 years ago

Good change. We could consider de-emphasizing the lbry:// portion as well.

Post https://github.com/lbryio/lbry/issues/958, when the claim ids should only be a few characters, we should consider showing them again.

tzarebczan commented 5 years ago

@Invariant-Change what else should we do on the current version to improve this? If it looks good, we can close it.

QuirkyRobots commented 5 years ago

It's looking good how it is, but would be a little better with end junk part being greyed out.

image

neb-b commented 5 years ago

Thanks for updating this. I agree

On Fri, Jul 19, 2019 at 3:03 AM Electron - Mark Firth < notifications@github.com> wrote:

It's looking good how it is, but would be a little better with end junk part being greyed out.

[image: image] https://user-images.githubusercontent.com/29914179/61515911-14ceae00-aa47-11e9-969f-b6a57edd8386.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lbryio/lbry-desktop/issues/2135?email_source=notifications&email_token=AEAZZDSD3ZWGCLK26O7GNL3QAFRMRA5CNFSM4GIIBYR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KY3RA#issuecomment-513117636, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAZZDRM5VFQFQ73MWR6PP3QAFRMRANCNFSM4GIIBYRQ .

-- Sean Yesmunt Engineer for lbry.com