Add new version / description on upgrade prompt

tzarebczan commented 5 years ago

The Issue

On the upgrade prompt for new versions, we should list the version and/or the tag from GitHub. Most times we add a release description which should suffice: "Clarke - 0.26.1". There will be a few different prompts to ad this one (one for auto, one for manual, and Linux).

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Internal Use

Acceptance Criteria

1. 2. 3.

Definition of Done

[ ] Tested against acceptance criteria
[ ] Tested against the assumptions of the user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

Ruk33 commented 3 years ago

How about showing the release changes in the app?

I just hacked a quick sample using GitHub's release api (found in https://docs.github.com/en/rest/reference/repos#releases):

The content is fetched from the latest release and then displayed using remark (markdown).

Does this works @tzarebczan ?

Regards.

tzarebczan commented 3 years ago

That looks great! Can we add the tag/version number next to "new version" ?

Ruk33 commented 3 years ago

We sure can:

Added loading state:

Added failure state:

Ruk33 commented 3 years ago

Alright, I just pushed the PR: https://github.com/lbryio/lbry-desktop/pull/5461 Regards!

lbryio / lbry-desktop