search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 413 forks source link

Translucent colors appear as black on both dark and light theme. #2602

Open Blanxs opened 5 years ago

Blanxs commented 5 years ago

The Issue

Translucent colors appear as black on both dark and light theme.

Steps to Reproduce

  1. Upload a thumbnail that has transparency 2. Check the image on the published files page on both dark and light theme

Expected Behavior

It should appear like this. image4

Or like this. image5

Actual Behavior

It instead appears like this. image3 image1

image2

Suggested Solutions

Let the app read translucent images and replace the translucency with lbryBlack= Color.decode("#212529"); for dark theme for example.

System Configuration

Anything Else

Screenshots

neb-b commented 5 years ago

The main reason we have a default background color is to deal with claims that have a thumbnail, but one that either isn't valid, or points to an out of date url. If changed this to be transparent, it would just be empty space, instead of a "missing" thumbnail

Blanxs commented 5 years ago

Could you catch the exception for the case of a thumbnail that isnt valid, and in the place of the thumbnail place the "missing" thumbnail?