Searching Everything only gets files

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.

https://lbry.tech

MIT License

3.56k stars 413 forks source link

Searching Everything only gets files #3377

Closed tiger5226 closed 2 years ago

tiger5226 commented 4 years ago

https://lighthouse.lbry.com/search?s=blah&size=30&from=0&claimType=file,channel

The above outbound query is being sent. claimType does not accept CSV. You can only pass file or channel as a value.

tiger5226 commented 4 years ago

ok looking at lighthouse it actually fails to add a claimType filter because it equals neither. So no filter means everything. So I guess its a bug that doesn't matter.

tzarebczan commented 4 years ago

https://github.com/lbryio/lighthouse/issues/153

tiger5226 commented 4 years ago

That's unrelated.

tiger5226 commented 4 years ago

This should be fixed at some point @tzarebczan to avoid messy behavior. However, since its not impacting users right now, maybe just mark it low priority. I will make a note in the code base of lighthouse so no one accidentally fixes my workaround to prevent it from failing.